CNDB-15946: Revamp SAI metrics for fetched/returned keys/partitions/rows/tombstones

[michaelsembwever]

https://github.com/riptano/cndb/issues/16180

Port into main-5.0 commit 4fc5df6

CNDB-15946: Revamp SAI metrics for fetched/returned keys/partitions/rows/tombstones (#2132)

The metrics partitionsRead, rowsFiltered, rowsPreFiltered and shadowedPrimaryKeyCount, which don't always work as expected, are replaced by these metrics:

* keysFetched: Number of partition/row keys that will be used to fetch rows from the base table.
* partitionsFetched: Number of live partitions fetched from the base table, before post-filtering and sorting. Note that currently ANN fetches one partition per index key, without any grouping of same-partition clusterings.
* partitionsReturned: Number of live partitions returned to the coordinator, after post-filtering and sorting.
* partitionTombstonesFetched: Number of deleted partitions found when reading the base table.
* rowsFetched: Number of live rows fetched from the base table, before post-filtering and sorting.
* rowsReturned: Number of live rows returned to the coordinator, after post-filtering and sorting.
* rowTombstonesFetched: Number deleted rows or row ranges found when reading the base table.

StorageAttachedIndexSearcher is modified to use the command timestamp, rather than getting the current time every time a query timestamp is needed, which was possibly buggy and inefficient.

[github-actions]

Checklist before you submit for review

• This PR adheres to the Definition of Done
• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits
• All new files should contain the DataStax copyright header instead of the Apache License one

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-2169 rejected by Butler

---

9 regressions found
See build details here

---

Found 9 new test failures

Test	Explanation	Runs	Upstream
o.a.c.concurrent.StageTimeMeasurementTest.executionAndQueueTimeAreCountedOnSubmitWithResult (compression)	NEW	🔴	0 / 26
o.a.c.config.DatabaseDescriptorRefTest.testDatabaseDescriptorRef (compression)	NEW	🔴	0 / 26
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression)	NEW	🔴	2 / 26
o.a.c.db.ColumnFamilyStoreTest.testSnapshotCreationAndDeleteEmptyTable ()	NEW	🔴	1 / 26
o.a.c.distributed.test.repair.ForceRepairTest.terminated successfully ()	NEW	🔴	1 / 26
o.a.c.index.SecondaryIndexManagerTest.testIndexRebuildWhenAddingSStableViaRemoteReload (compression)	NEW	🔴	20 / 26
o.a.c.repair.FailedAckTest.failedAck ()	NEW	🔴	0 / 26
o.a.c.repair.FailingRepairFuzzTest.failingRepair ()	NEW	🔴	0 / 26
o.a.c.repair.SlowMessageFuzzTest.slowMessages (compression)	NEW	🔴	0 / 26

---

Found 3 known test failures

[michaelsembwever]

Tests failures not related. (already exist or not reproducible locally)