Skip to content

Conversation

@szymon-miezal
Copy link

@szymon-miezal szymon-miezal commented Dec 11, 2025

Ports CASSANDRA-19483 which added an option to group invalid legacy protocol magic exception with an no-spam logger.

The test was slightly modified, it contains the timeout for log watching and ensure the logs start from the mark that happens before the exception. It ensures the test does not hang without the fix it covers.

CNDB PR: https://github.com/riptano/cndb/pull/16273

The motivation behind the port is to fix https://datastax.jira.com/browse/DSP-24639

Ports CASSANDRA-19483 which added an option to group invalid
legacy protocol magic exception with an no-spam logger.

The test was slightly modified, it contains the timeout for log watching
and ensure the logs start from the mark that happens before the exception.
It ensures the test does not hang without the fix it covers.
@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2170 rejected by Butler


2 regressions found
See build details here


Found 2 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompaction[dc true] NEW 🔴 0 / 19
o.a.c.index.sai.cql.VectorSiftSmallTest.testSiftSmall[dc false] REGRESSION 🔴 0 / 19

Found 3 known test failures

@jkni jkni self-requested a review December 11, 2025 15:29
Copy link

@jkni jkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@szymon-miezal szymon-miezal merged commit 1200c45 into main Dec 12, 2025
490 of 500 checks passed
@szymon-miezal szymon-miezal deleted the HCD-247 branch December 12, 2025 20:47
szymon-miezal added a commit that referenced this pull request Dec 12, 2025
Ports CASSANDRA-19483 which added an option to group invalid legacy
protocol magic exception with an no-spam logger.

The test was slightly modified, it contains the timeout for log watching
and ensure the logs start from the mark that happens before the
exception. It ensures the test does not hang without the fix it covers.

The motivation behind the port is to fix
https://datastax.jira.com/browse/DSP-24639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants