Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Dec 11, 2025

What is the issue

ReadCommandVerbHandler was catching RejectException and returning an empty response instead of propagating the failure when warnings tracking was enabled.

What does this PR fix and why was it fixed

TombstoneOverwhelmingException is always re-thrown regardless of warning tracking state.

@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

@driftx driftx requested review from djatnieks and michaelsembwever and removed request for djatnieks and michaelsembwever December 11, 2025 18:27
Copy link
Member

@michaelsembwever michaelsembwever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be upstreamed too ?

@driftx
Copy link
Author

driftx commented Dec 11, 2025

Will do that after merge so I can reference the commit.

@driftx driftx merged commit f1223ec into main-5.0 Dec 11, 2025
572 of 592 checks passed
@driftx driftx deleted the CNDB-16277 branch December 11, 2025 21:20
@michaelsembwever
Copy link
Member

michaelsembwever commented Dec 11, 2025

Will do that after merge so I can reference the commit.

It's also nice to have the cassandra ticket id in the commit msg (so the rebaser on the next rebase knows whether to keep or skip the commit).
(I'm thinking if that's our practice then it removes any pressure of actually merging that ticket, let it be lazy and opportunistic)
(not important for this pr, just discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants