CNDB-16289: switch index hints limit to use Short.MAX_VALUE

[driftx]

What is the issue

Currently maxIncludedOrExcludedIndexCount is using getSecondaryIndexesPerTableFailThreshold but the coordinator will always validate that the indexes mentioned by the index hints exist in the schema, and there cannot be repeated index in the hints because the hints are disjoint sets. So the number of index hints is implicitly limited by the number of existing indexes, therefore we should use Short.MAX_VALUE like main does.

What does this PR fix and why was it fixed

Change the index hint limit to use Short.MAX_VALUE

[github-actions]

Checklist before you submit for review

• This PR adheres to the Definition of Done
• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits
• All new files should contain the DataStax copyright header instead of the Apache License one

[adelapena]

The coordinator will always validate that the indexes mentioned by the index hints exist in the schema, and there cannot be repeated index in the hints because the hints are disjoint sets. So the number of index hints is implicitly limited by the number of existing indexes. I don't see why we should check a guardrail to limit the number of hints.

Maybe a reason could be that the guardrail has changed to a value lower than the number of existing indexes? But even in that case it's odd to use the guardrail for SAI when the hints could contain other indexes. I think if we want to use a guardrail we could instead count the number of hints referencing an index of each kind and apply the relevant guardrail.

[driftx]

Updated to bring this in line with main, checking Short.MAX_VALUE and no guardrails.

[adelapena]

LGTM, +1.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-2174 rejected by Butler

---

7 regressions found
See build details here

---

Found 7 new test failures

Test	Explanation	Runs	Upstream
o.a.c.cql3.validation.operations.AggregationQueriesTest.testAggregationQueryShouldNotTimeoutWhenItExceedesReadTimeout (compression)	NEW	🔴🔴	2 / 26
o.a.c.db.commitlog.BatchCommitLogTest.testBatchCLShutDownImmediately[1] (compression)	NEW	🔵🔴	0 / 26
o.a.c.index.SecondaryIndexManagerTest.testIndexRebuildWhenAddingSStableViaRemoteReload (compression)	NEW	🔴🔴	20 / 26
o.a.c.metrics.TrieMemtableMetricsTest.testContentionMetrics (compression)	NEW	🔴🔵	9 / 26
o.a.c.repair.FailedAckTest.failedAck ()	NEW	🔴🔴	0 / 26
o.a.c.repair.FailingRepairFuzzTest.failingRepair ()	NEW	🔴🔴	0 / 26
o.a.c.repair.SlowMessageFuzzTest.slowMessages (compression)	NEW	🔴🔴	0 / 26

---

Found 3 known test failures