Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Dec 15, 2025

What is the issue

After CNDB-16249, hints are written with the storage-compatible messaging version (e.g., VERSION_40), but dispatch was still using the peer's negotiated version (VERSION_DS_20). This mismatch forced hints to be decoded and re-encoded on dispatch, which fails when the tenant is unassigned because tables are unknown.

What does this PR fix and why was it fixed

Cap the dispatch version to the storage compatibility mode's version so hints can use the encoded path (no deserialization) when the versions match.

@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

@sonarqubecloud
Copy link

@cassci-bot
Copy link

@djatnieks
Copy link

Would these improvements make sense in Apache C* 5.0 too?

@djatnieks
Copy link

Is this expected to fix the HintedHandoff test in CNDB (seems like it)?

@driftx
Copy link
Author

driftx commented Dec 16, 2025

Would these improvements make sense in Apache C* 5.0 too?

Maybe all of CNDB-16249 once I finish fixing the bugs.

Is this expected to fix the HintedHandoff test

Yep!

@driftx driftx merged commit 7d8f28b into main-5.0 Dec 16, 2025
580 of 594 checks passed
@driftx driftx deleted the CNDB-16307 branch December 16, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants