Skip to content

Conversation

@michaeljmarshall
Copy link
Member

What is the issue

Fixes https://github.com/riptano/cndb/issues/16252

What does this PR fix and why was it fixed

Add a new method to the IndexComponents.ForWrite interface named tmpFileFor. The new method is expected to create temporary files that are namespaced to the index build. This fixes an issue in the CompactionGraph where we incorrectly created temp files with the same name in such a way that they collided. Now the files have the column name and the build id, so they will be properly namespaced while maintaining some form of meaningful name.

@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@cassci-bot
Copy link

❌ Build ds-cassandra-pr-gate/PR-2177 rejected by Butler


2 regressions found
See build details here


Found 2 new test failures

Test Explanation Runs Upstream
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompaction[db true] NEW 🔴 0 / 19
o.a.c.index.sai.cql.VectorKeyRestrictedOnPartitionTest.partitionRestrictedTest[eb false] (compression) REGRESSION 🔴🔵 0 / 19

Found 1 known test failures

@michaeljmarshall michaeljmarshall merged commit f358303 into main Dec 19, 2025
488 of 498 checks passed
@michaeljmarshall michaeljmarshall deleted the cndb-16252 branch December 19, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants