Skip to content

Conversation

@driftx
Copy link

@driftx driftx commented Dec 16, 2025

What is the issue

Fix version mismatch error when dispatching encoded hints in storage compatibility mode

What does this PR fix and why was it fixed

Remove version checks in HintMessage.Encoded serialization that prevented dispatching hints written at storage compatibility version (e.g., 12) when the peer connection uses a different messaging version (e.g., 110).

UUID and VInt serialization are version-independent, and hint bytes are written verbatim, so the version check was unnecessarily restrictive.

@github-actions
Copy link

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the DataStax copyright header instead of the Apache License one

Copy link

@djatnieks djatnieks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: are the removed version checks still performed (needed?) later in the execution path?

@driftx
Copy link
Author

driftx commented Dec 16, 2025

Q: are the removed version checks still performed (needed?) later in the execution path?

I don't think so, I tested with the branch pushed to my local maven repo and CNDB and things passed. But I thought I did that with the last hint problem too and here we are, so I could be wrong.

@driftx driftx merged commit c36fbcf into main-5.0 Dec 16, 2025
500 of 520 checks passed
@driftx driftx deleted the CNDB-16313 branch December 16, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants