CNDB-16237: Add execution info to logs about aborted queries #2182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
CNDB-15260 added SAI-specific execution information to the log reports produced for slow queries, and CNDB-15260 will soon add generic execution information for all non-SAI read commands. These details are produced only for queries that are reported as slow but successful by
MonitoringTask. However,MonitoringTaskalso produces log reports for queries that are slow enough to be aborted. We should probably also add execution information to the log reports for aborted queries.What does this PR fix and why was it fixed
Adds execution information to the log reports for aborted queries. The extension of the log messages is identical to what we did for slow successful queries in CNDB-15260 and CNDB-15260, but applied to aborted queries:
This also renames the
CassandraRelevantPropertiesrelated to monitoring, to align them with ASF/CC5. The renames are:SLOW_QUERY_LOG_MONITORING_REPORT_INTERVAL_IN_MS->MONITORING_REPORT_INTERVAL_MSSLOW_QUERY_LOG_MONITORING_MAX_OPERATIONS->MONITORING_MAX_OPERATIONSSLOW_QUERY_LOG_EXECUTION_INFO_ENABLED->MONITORING_EXECUTION_INFO_ENABLEDSAI_SLOW_QUERY_LOG_EXECUTION_INFO_ENABLED->SAI_MONITORING_EXECUTION_INFO_ENABLEDThis naming also makes more sense considering that monitoring is applied to both slow and aborted queries.
Please note that the real underlying system properties are unchanged, and this only renames their enum names.
All four enums are not present in any CC release yet.