CNDB-14868 Add system property to always consider the remote peer supporting repair message timeouts.#2185
Merged
maxtomassi merged 3 commits intomainfrom Jan 21, 2026
Merged
CNDB-14868 Add system property to always consider the remote peer supporting repair message timeouts.#2185maxtomassi merged 3 commits intomainfrom
maxtomassi merged 3 commits intomainfrom
Conversation
Checklist before you submit for review
|
jasonstack
approved these changes
Dec 19, 2025
…porting repair message timeouts. Right now the peer's version is checked to figure out if timeouts are supported, but that doesn't work in CNDB, as repair services are not added to the Nodes.peers() table, so there's no clear way to check what version a remote peer is running on. The newly introduced system property allows to skip this version check and always consider timeouts supported by the remote peer.
maxtomassi
force-pushed
the
CNDB-14868
branch
from
8fca163 to
fe142c0
Compare
…t for repair timeouts is checked. Moved away from reading the system property in the static initialization to make it more testable
Author
|
@jasonstack I added a test in this commit 5a96265 as CI was complaining about code coverage. Would you mind having another look? Thanks! |
jasonstack
approved these changes
Jan 20, 2026
|
❌ Build ds-cassandra-pr-gate/PR-2185 rejected by Butler4 regressions found Found 4 new test failures
Found 2 known test failures |
Author
|
Failing tests seem to be unrelated. I'm going to merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
A repair task would hang forever if a timeout for validate or sync request is reached. This was happening because the repair initiator (the repair service in the primary region) would consider the peer repair service as not supporting timeouts, and therefore it would not fail the repair task, leaving it hanging. This behavior is due to the way C* used to detect if a peer supports repair timeouts, which is by checking the C* version of the peer in the
Nodes.peers()table. In CNDB, though, the repair services (or external services in general) are not added to the peers as they are not handled by the ServiceTracker.What does this PR fix and why was it fixed
Add system property to always consider the remote peer supporting repair message timeouts.
Right now the peer's version is checked to figure out if timeouts are supported, but that doesn't work in CNDB, as repair services are not added to the Nodes.peers() table, so there's no clear way to check what version a remote peer is running on. The newly introduced system property allows to skip this version check and always consider timeouts supported by the remote peer.