CNDB-13742 ReadCallback logs when replica doesn't respond#2237
Closed
CNDB-13742 ReadCallback logs when replica doesn't respond#2237
Conversation
Checklist before you submit for review
|
zgorzalyj
force-pushed
the
CNDB-13742
branch
from
db2c7b9 to
1a9d029
Compare
|
@driftx could you please review this one and let Jakub know if he's going in the right direction? |
driftx
reviewed
Mar 5, 2026
driftx
left a comment
driftx
left a comment
There was a problem hiding this comment.
There is significant formatting "noise" that may be the result of an IDE setting, I'm not sure, but otherwise this appears to be on the right path.
| import java.util.Optional; | ||
|
|
||
| import org.apache.commons.lang.StringUtils; | ||
| import org.apache.commons.lang3.StringUtils; |
Author
There was a problem hiding this comment.
It was only occurrence of commons-lang. Everywhere else we use commons-lang3, so I updated it here for consistency
zgorzalyj
force-pushed
the
CNDB-13742
branch
2 times, most recently
from
fbb02ae to
fcfbe3b
Compare
…llback - Add timeout logging with elapsed time for both failure and timeout scenarios - Add unit tests to verify MonotonicClock usage in timeout logging - Update CompactionParams to use commons-lang3 instead of commons-lang
|
❌ Build ds-cassandra-pr-gate/PR-2237 rejected by Butler3 regressions found Found 3 new test failures
Found 5 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/riptano/cndb/issues/13742
Lack of information when replica doesn't respond.
Changes
Add new log which contains information about timeout