CNDB-16859: Use SinglePartitionReadCommand for index queries#2253
Open
CNDB-16859: Use SinglePartitionReadCommand for index queries#2253
Conversation
Checklist before you submit for review
|
72999d2 to
35b0b6a
Compare
35b0b6a to
4e28713
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What is the issue
Historically all queries using indexes have been treated as a
PartitionRangeReadCommand. I think was done mostly for simplicity, but it has a number of caveats:CASSANDRA-19968 has changed this in ASF
trunkso index queries targeting a single partition becomeSinglePartitionReadCommand. However, I think this change is not included in the currentmain-5.0. Probably we should bring in that change to CC too.What does this PR fix and why was it fixed
Use
SinglePartitionReadCommandfor index queries for a single partition.