CNDB-16145: Split VectorSiftSmallTest to prevent JUnit timeouts#2263
Open
CNDB-16145: Split VectorSiftSmallTest to prevent JUnit timeouts#2263
Conversation
Checklist before you submit for review
|
❌ Build ds-cassandra-pr-gate/PR-2263 rejected by Butler3 regressions found Found 3 new test failures
Found 3 known test failures |
Member
|
We certain can keep this change, but in my recent testing of some CI pipeline improvements https://github.com/riptano/jenkins-pipeline-lib/pull/250, I discovered that this test goes from ~25 minutes to ~8 minutes, so it will be much more likely to succeed without needing to split it out. I haven't reviewed it yet, but I think we should wait until https://github.com/riptano/jenkins-pipeline-lib/pull/250 lands (hopefully tomorrow) before merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
VectorSiftSmallTestfrequently hits JUnit timeouts, likely due to the test being too long.What does this PR fix and why was it fixed
Splits
VectorSiftSmallTestinto multiple smaller tests.Please note that this doesn't aim to fix https://github.com/riptano/cndb/issues/16316, which is a separate problem.