-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove stale dependency on "sure" #1227
base: master
Are you sure you want to change the base?
Conversation
Good find @a-detiste! I've kicked off a Jenkins build just to confirm there aren't any unexpected regressions here but I'll be surprised if anything comes of it. Assuming there isn't a problem this should go in right away! |
Hey @a-detiste , unfortunately the Jenkins build detected a collection of new failures, most (or actually I think all?) in tests/integration/cqlengine/test_timestamp.py. That looks to be the only test that was using the "sure" module but apparently it was using it; when I run the integration test locally with your branch I get the following:
That "should" function appears to be part of the DSL provided by sure so if we're going to remove the dependency we'll need to replace all those usages with something else. |
Indeed ... but it also means that nobody knows how |
"sure" was a popular helper to "nose" ... a long time ago