-
Notifications
You must be signed in to change notification settings - Fork 89
fix typos and latest shiny compatibility #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ismirsehregal
wants to merge
16
commits into
datastorm-open:master
Choose a base branch
from
ismirsehregal:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a few typos
[...] please note the following: the colon is never preceded by a white space; it is always followed by a single white space in normal use [...] source: https://www.sussex.ac.uk/informatics/punctuation/colonandsemi/colon
This resolves datastorm-open#198
Removed preceding whitespace for colons in default labels
undo changes
undo changes
remove focus_input call and set autofocus on textInput user_id instead
removed custom message handler 'focus_input'
Instead of using actionButton: Passing a list of arguments to fab_button (more secure, to be handled correctly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few typos - e.g.: README typo: create_db_sql instead of create_sql_db #200
Removed preceding whitespace for colons in default labels
[...] please note the following: the colon is never preceded by a white space; it is always followed by a single white space in normal use [...]
source: https://www.sussex.ac.uk/informatics/punctuation/colonandsemi/colon
Fixed: focus_input event fires too late for long running server functions #217
Fixed: Malformed labels using latest shiny (dev) version #219