Confirmation time default #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccles
requested review from
waarg,
JAG-UK,
j-hartley,
Serhiy1 and
rcoxhill-01
rcoxhill-01
reviewed
Aug 23, 2024
rcoxhill-01
previously approved these changes
Aug 23, 2024
A number of places set the wrong default confirmation time of 30s instead of 300s Additionally latest linter highlighted incorrect and unused imports in notebooks. AB#9779
eccles
force-pushed
the
dev/paul/9779-confirmation-max-time-default
branch
from
ea4a980 to
5c16995
Compare
rcoxhill-01
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of places set the wrong default confirmation time of 30s instead of 300s
Additionally new linter highlighted incorrect imports in the notebooks.
Test results:
AB#9779