Skip to content

Add support for python 3.13 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2024
Merged

Add support for python 3.13 #273

merged 4 commits into from
Nov 20, 2024

Conversation

eccles
Copy link
Contributor

@eccles eccles commented Nov 19, 2024 •
edited
Loading

Remove support for python 3.8.

Upgrade all dependencies

Replaced sphinx docs googleanalytics module as current one is deprecated

New code formatter has reformatted some code.

New merge-checks github action implemented.

Testing

all unittests pass for all versions in the CI

task functests passed

task functests
task: [about] ./scripts/builder.sh ./scripts/version.sh
task: [functests] ./scripts/builder.sh ./scripts/functests.sh
Python 3.9.20
test_access_policies_share_asset_with_different_attributes (functests.execaccess_policies.TestAccessPoliciesShare) ... skipped 'cannot run test as DATATRAILS_AUTHTOKEN_FILENAME_2 is not set'
test_access_policies_share_assets_symmetrically (functests.execaccess_policies.TestAccessPoliciesShare) ... skipped 'cannot run test as DATATRAILS_AUTHTOKEN_FILENAME_2 is not set'
test_access_policies_create (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_delete (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_list (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_access_policies_update (functests.execaccess_policies.TestAccessPoliciesSimple) ... ok
test_appidp_token (functests.execapplications.TestApplications) ... ok
test_appidp_token_404 (functests.execapplications.TestApplications) ... ok
test_applications_create (functests.execapplications.TestApplications) ... ok
test_applications_delete (functests.execapplications.TestApplications) ... ok
test_applications_list (functests.execapplications.TestApplications) ... ok
test_applications_regenerate (functests.execapplications.TestApplications) ... ok
test_applications_update (functests.execapplications.TestApplications) ... ok
test_archivist_token (functests.execapplications.TestApplications) ... skipped 'cannot run test as DATATRAILS_REFRESH_TOKEN is not set'
test_asset_create (functests.execassets.TestAssetCreate) ... ok
test_asset_create_event (functests.execassets.TestAssetCreate) ... ok
test_asset_create_merkle_log (functests.execassets.TestAssetCreate) ... ok
test_asset_create_with_fixtures (functests.execassets.TestAssetCreate) ... ok
test_asset_create_if_not_exists_with_bad_attachment (functests.execassets.TestAssetCreateIfNotExists) ... ok
test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execassets.TestAssetCreateIfNotExists) ... ok
test_attachment_info (functests.execattachments.TestAttachmentsCreate) ... skipped 'cannot run test as DATATRAILS_BLOB_IDENTITY is not set'
test_attachment_upload_and_download (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_allow_insecure (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_docx (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_upload_and_download_strict (functests.execattachments.TestAttachmentsCreate) ... ok
test_attachment_malware_scan1 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan2 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan3 (functests.execattachments.TestAttachmentstMalware) ... ok
test_attachment_malware_scan4 (functests.execattachments.TestAttachmentstMalware) ... ok
test_compliance_policies_count (functests.execcompliance_policies.TestCompliancePolicies) ... ok
test_compliance_policies_list (functests.execcompliance_policies.TestCompliancePolicies) ... ok
test_compliancepolicies_create_current_outstanding (functests.execcompliance_policies.TestCompliancePolicies) ... ok
test_compliancepolicies_create_dynamic_tolerance (functests.execcompliance_policies.TestCompliancePolicies) ... ok
test_compliancepolicies_create_period_understanding (functests.execcompliance_policies.TestCompliancePolicies) ... ok
test_compliancepolicies_create_richness (functests.execcompliance_policies.TestCompliancePolicies) ... ok
test_compliancepolicies_create_since (functests.execcompliance_policies.TestCompliancePolicies) ... ok
test_compliancepolicies_current_outstanding (functests.execcompliance_policies.TestCompliancePoliciesCompliantAt) ... ok
test_compliancepolicies_since (functests.execcompliance_policies.TestCompliancePoliciesCompliantAt) ... ok
test_01_create_artist_albuminfo (functests.execnotebooks.TestNotebooks) ... ok
test_02_find_artist_create_coverart (functests.execnotebooks.TestNotebooks) ... ok
test_03_find_artist_addtl_albuminfo (functests.execnotebooks.TestNotebooks) ... ok
test_check_asset_compliance_current_outstanding (functests.execnotebooks.TestNotebooks) ... ok
test_check_asset_compliance_since (functests.execnotebooks.TestNotebooks) ... ok
test_check_dogs_weight (functests.execnotebooks.TestNotebooks) ... ok
test_create_event_with_verified_domain (functests.execnotebooks.TestNotebooks) ... ok
test_feed_dog_timelymanner (functests.execnotebooks.TestNotebooks) ... ok
test_feed_the_dog (functests.execnotebooks.TestNotebooks) ... ok
test_feed_the_doghourly (functests.execnotebooks.TestNotebooks) ... ok
test_playing_fetch_fiveminutes (functests.execnotebooks.TestNotebooks) ... ok
test_share_album_release_recordlabel (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_album_release_user (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_artist_asset_recordlabel (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials -- see #7742'
test_share_artist_asset_user (functests.execnotebooks.TestNotebooks) ... skipped 'Requires root access credentials - see #7742'
test_asset_create_if_not_exists_with_bad_attachment_assetattachment (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_public_asset_create (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_public_asset_create_event (functests.execpublicassets.TestPublicAssetCreate) ... ok
test_runner_door_entry (functests.execrunner.TestRunner) ... ok
test_runner_dynamic_tolerance (functests.execrunner.TestRunner) ... ok
test_runner_estate_info (functests.execrunner.TestRunner) ... ok
test_runner_richness (functests.execrunner.TestRunner) ... ok
test_runner_subjects (functests.execrunner.TestRunner) ... ok
test_runner_synsation (functests.execrunner.TestRunner) ... ok
test_runner_wipp (functests.execrunner.TestRunner) ... ok
test_subjects_count (functests.execsubjects.TestSubjects) ... ok
test_subjects_create (functests.execsubjects.TestSubjects) ... ok
test_subjects_create_b64 (functests.execsubjects.TestSubjects) ... ok
test_subjects_delete (functests.execsubjects.TestSubjects) ... ok
test_subjects_list (functests.execsubjects.TestSubjects) ... ok
test_subjects_update (functests.execsubjects.TestSubjects) ... ok

----------------------------------------------------------------------
Ran 69 tests in 221.298s

OK (skipped=8)

AB#10062

@eccles eccles force-pushed the dev/paul/10062-python-3-13 branch 2 times, most recently from 6d6a277 to 3786281 Compare November 19, 2024 17:04
@eccles
Add support for python 3.13
fd4dcd0 
Remove support for python 3.8.

Upgrade all dependencies

Replaced sphinx docs googleanalytics module as current one is
deprecated.

Reformatted code using new version of black..

Use new merge-requires github action

AB#10062
@eccles eccles force-pushed the dev/paul/10062-python-3-13 branch from 3786281 to fd4dcd0 Compare November 19, 2024 17:28
robinbryce
robinbryce reviewed Nov 20, 2024
View reviewed changes
robinbryce
robinbryce previously approved these changes Nov 20, 2024
View reviewed changes
Copy link

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robinbryce
robinbryce previously approved these changes Nov 20, 2024
View reviewed changes
Copy link

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

robinbryce
robinbryce approved these changes Nov 20, 2024
View reviewed changes
Copy link

@robinbryce robinbryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

@eccles eccles merged commit 7710adb into main Nov 20, 2024
15 checks passed
@eccles eccles deleted the dev/paul/10062-python-3-13 branch November 20, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinbryce robinbryce robinbryce approved these changes

@JAG-UK JAG-UK Awaiting requested review from JAG-UK

@j-hartley j-hartley Awaiting requested review from j-hartley

@rcoxhill-01 rcoxhill-01 Awaiting requested review from rcoxhill-01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eccles @robinbryce