Upgrade to go 1.24

.env.tools

@@ -1,2 +1 @@
-export TOOLS_BUILDNUMBER=20241108.3
-
+export TOOLS_BUILDNUMBER=20250415.2

.github/workflows/push.yaml

@@ -10,7 +10,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '1.23'
+          go-version: '1.24'
           cache: false
       - name: Check formatting
         uses: Jerome1337/[email protected]
@@ -30,7 +30,7 @@ jobs:
           # Require: The version of golangci-lint to use.
           # When `install-mode` is `binary` (default) the value can be v1.2 or v1.2.3 or `latest` to use the latest version.
           # When `install-mode` is `goinstall` the value can be v1.2.3, `latest`, or the hash of a commit.
-          version: v1.60
+          version: v1.64.2
       - name: Install Task
         uses: arduino/setup-task@v2
         with:

.golangci.yml

@@ -86,6 +86,9 @@ linters-settings:
   goimports:
     local-prefixes: github.com/golangci/golangci-lint
   govet:
+    enable-all: true
+    disable:
+      - fieldalignment
     settings:
       printf:
         funcs:
@@ -107,8 +110,6 @@ linters-settings:
 # goconst - see ticket #3097
 # goerr113 - disabled see https://github.com/Djarvur/go-err113/issues/10
 # gofumpt - not useful - confusing messages
-# gomnd - see ticket #3116
-# govet - see ticket #3117
 # nilreturn onwardis not yet evaluated...
 # misspell - expected UK spelling with misspell, but customer facing text needs to be US.
 # tagalign - suppress until we can get a golang code formatter that will fix this (cosmetic)
@@ -130,9 +131,7 @@ linters:
     - err113
     - errchkjson
     - errname
-    - execinquery
     - exhaustruct
-    - exportloopref
     - forbidigo
     - forcetypeassert
     # DONT re-enable funlen please
@@ -146,7 +145,6 @@ linters:
     - godox
     - gofumpt
     - gomoddirectives
-    - gomnd
     - gosec
     - gosimple
     - inamedparam

azblob/download.go

@@ -119,7 +119,7 @@ func (azp *Storer) Reader(
 			return nil, metadataErr
 		}
 		if parseErr := readerResponseMetadata(resp, metaData); parseErr != nil {
-			return nil, err
+			return nil, parseErr
 		}
 	}
 

go.mod

@@ -1,6 +1,6 @@
 module github.com/datatrails/go-datatrails-common
 
-go 1.23.0
+go 1.24
 
 require (
 	github.com/Azure/azure-sdk-for-go v68.0.0+incompatible
@@ -18,7 +18,7 @@ require (
 
 require (
 	github.com/Azure/azure-sdk-for-go/sdk/azcore v1.17.0 // indirect
-	github.com/Azure/go-autorest/autorest v0.11.29 // indirect
+	github.com/Azure/go-autorest/autorest v0.11.28 // indirect
 	github.com/AzureAD/microsoft-authentication-library-for-go v1.3.3 // indirect
 	github.com/golang-jwt/jwt/v5 v5.2.2 // indirect
 	github.com/kylelemons/godebug v1.1.0 // indirect