Dev/robin/10530 replicate logs races with sealer regression test #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 13, 2025 09:58
When replicating the remote massif, prior to updating the local replica, we fetch the massif and *then* fetch the seal. This means the log can grow *and* be re-sealed after the massif is fetched but before the seal is fetched. With the result that the fetched massif is shorter than the fetched seal This race is excacerbated by our rate limiting. This change ensures that veracity fetches the seal before fetching the massif. this guarantees that even if the massif grows, the fetched seal will have sufficient data in the massif to be verifiable. The remainder, tail of the massif, will be verified by the consistency check for the *next* massif. It does not matter if replication terminates without verifying the tail of the last massif. Because the next time it runs it will.
AB#10530
…tigating a 'fail'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.