Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow docker image to be multiarchitecture #445

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

Jakan-Kink
Copy link

@Jakan-Kink Jakan-Kink commented Aug 15, 2024

This pull request tells the docker builds to generate both amd64 and arm64 builds.
It also has ffmpeg and the latest fixuid bundled in.

Accidentally used the wrong ARCH, it worked on my machine since I use Apple Silicon
Reduce the finished file size by moving the install of cmake into the bento4 stage
it would help if I tell apt-get yes
@Jakan-Kink
Copy link
Author

Hold this PR until I finish removing the bento4 install since mp4decrypt was removed way back in 93dda36

remove all of the bento4 instructions from the Dockerfile since its use was removed in 93dda36
@Jakan-Kink
Copy link
Author

Based on discussions on discord. (Around https://discord.com/channels/1093562233612673097/1111026840799285399/1275857259527667765 )
This code may be broken down even more, to switch to building 2 images, one with / one without ffmpeg, and possibly switch from python:3.11 to python:3.11-alpine for further optimizations

dependabot doesn't like "" for the package-ecosystem, so just set it to github-actions
upgrade the github-action dependencies in daily-docker and release_bundler
rename the Dockerfile with ffmpeg to Dockerfile.full
Add Dockerfile for python:3.11 without ffmpeg
Add Dockerfiles for python:3.11-alpine both with and without ffmpeg
Add Dockerfiles for python:3.12-alpine both with and without ffmpeg
make sure ffmpeg's install on the full is no-cache
have bash, git, curl as part of the base
move build-base and linux-headers to the builder stage
@datawhores
Copy link
Owner

datawhores commented Aug 24, 2024

The dockerfiles look good
but it doesn't seem like the github actions I have setup use docker files to be generate the docker images

@Jakan-Kink
Copy link
Author

The dockerfiles look good but it doesn't seem like the github actions I have setup use docker files to be generate the docker images

I'm actually working on that right now, switching from using the build-push-action GHA to the bake-action GHA, in fact for the moment lemme switch this PR back to draft

@Jakan-Kink Jakan-Kink marked this pull request as draft August 24, 2024 04:09
make sure of the buildx bake functionality so that there are templates and other fun feature sets including fun tagging of docker releases
on docker-daily correct the job name from release_github to release_dockerhub
split the bakes into two different files depending on how they are called
update to version 3
attempt to safely handle multi-arch packages
python numbered only releases are debian not ubuntu (currently debian bookworm) 🤦
correct the file name of the bake-action in release_bundler
fiddle around more with the repository name value
make sure to include the output from the metadata-action (so labels / annotations)
* main: (75 commits)
  changes to leaky bucket
  Fix infinite loop setting directory date
  expand max post count
  cache reset
  retry when cdrm fails
  reset key and don't cache until confirm new path
  move subprocess main thread reset
  fix  count for 0 downloads after  a user with downloads in normal downloader
  increase chunk size
  add reader
  import metadata
  remove bold yellow and for message
  fix error with new line in key
  change cdrm url and process
  remove binaries
  disable binaries
  fix scrape paid
  change cache keys for our v2 of api
  only allow multiprocess on Linux
  replace manager with manager2
  ...
@Jakan-Kink Jakan-Kink changed the base branch from dev/3.11 to main September 13, 2024 07:49
…ultiplatform

* commit 'ddae54d9e8cbb7cebae422e09ca7aa2608e1ab25':
  fix neg filter
  set processs higher up
  remove test line
  remove line
  set after to zero if like is in actions
  add link to media and fix db media updte
  remove redundanct log
  reword
  change how get after works and change wording
  remove more forced after
  remove forced after
  move setting after in check mode
  fix linked
  update linked
  make windows binaries again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants