Skip to content

Follows PEP 8 Python code convention and format #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bact wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Follows PEP 8 Python code convention and format #20

bact wants to merge 4 commits into from

Conversation

@bact
Copy link

@bact bact commented Nov 16, 2019 •
edited
Loading

  • Replace comparisons with None from == None to is None and from != None to is not None
  • Drop unnecessary comparisons when obvious, follows Python convention that if a value is not None/False/zero/empty, it is True in a boolean test
  • Drop ; semicolons at the end of some statements
  • Formatted with black, remove trailing spaces
  • Use with context manager for open files

bact added 2 commits November 16, 2019 20:12
@bact
- Replace comparisons with None from "==" to "is" and from "!=" to "i…
e59165c 
…s not"

- Drop unnecessary comparison, follows Python convention of default True value if a value is not None
- Formatted with black
@bact
use "with" context manager when open files
ec8025e
@bact bact changed the title Code convention and format Python code convention and format Nov 16, 2019
@bact bact changed the title Python code convention and format Follows PEP 8 Python code convention and format Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bact