Skip to content

Update to new version of compact encodable and use it Clean up encoding implementations #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
May 6, 2025

Conversation

cowlicks
Copy link
Member

@cowlicks cowlicks commented Apr 30, 2025

This updates the crate to use the updated version of the compact encoding crate. The main parts:

  • Rewrites of the CompactEncoding implementations. There are a lot of these but they are fairly simple.
  • Removes the HypercoreState struct. This is no longer needed due to changes to upstream compact encoding. This was used downstream in the hypercore-protocol crate (fixed in this PR).
  • Rewriting of src/oplog/mod.rs::ValidateLeaderOutcome this struct heavily used the HypercoreState struct so rewriting it was more involved.
  • This also removes the re-exports of compact-encoding from encoding.rs I believe this was added when the compact-encoding crate was created because hypercore-protocol depndended on the encoding code here before it was moved to it's own crate

@cowlicks cowlicks force-pushed the update-encodable branch from bdf3dc6 to 860eeb5 Compare May 5, 2025 19:00
@cowlicks cowlicks marked this pull request as ready for review May 5, 2025 19:01
Copy link
Member

@ttiurani ttiurani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me!

@cowlicks cowlicks merged commit a4d5752 into datrs:master May 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants