-
Notifications
You must be signed in to change notification settings - Fork 35
Update to new version of compact encodable and use it Clean up encoding implementations #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why this was not an error before
ttiurani
approved these changes
May 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straightforward to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the crate to use the updated version of the compact encoding crate. The main parts:
CompactEncoding
implementations. There are a lot of these but they are fairly simple.HypercoreState
struct. This is no longer needed due to changes to upstream compact encoding. This was used downstream in thehypercore-protocol
crate (fixed in this PR).src/oplog/mod.rs::ValidateLeaderOutcome
this struct heavily used theHypercoreState
struct so rewriting it was more involved.encoding.rs
I believe this was added when thecompact-encoding
crate was created becausehypercore-protocol
depndended on the encoding code here before it was moved to it's own crate