Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a gradle build. #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a gradle build. #23

wants to merge 1 commit into from

Conversation

ed8247
Copy link

@ed8247 ed8247 commented Jun 25, 2015

I am not sure if you want one, but I thought I would offer my work if you were interested. Because we wanted to segregate this source from our projects source I added a gradle build system. I thought I would offer it to you because I didn't change any of the layout you already have. I created the build around your project. Because it is a build system, I find that there is typically some work involved in getting it jright for any particular project so I understand if this isn't something you want. Some of the things of note for the build.

  1. I tried to provide defaults for the jar name (ie with no additional properties the jar would be AceGWT-0.0.1-SNAPSHOT.jar)
  2. It is setup to install to your local .m2 repo
  3. A user can add a gradle.properties file to override some defaults. Also providing a repository_url property will also allow a user to publish the jar to an external repo like nexus, so long as auth isn't required.

Of course there are things that are missing. Most notably I haven't added a mvn build. And it may take a few others experiences to iron out settings just right for this project but if you are interested this could be something to start with.

@ainslec
Copy link
Collaborator

ainslec commented Jun 25, 2015

I don't object to having a gradle build.

I reviewed the changes and they look pretty general to me. Of course the client machine might need some setup (not sure if gradle requires a maven install to use the .m2 repo folder), but my take-away from this is that it doesn't break anything that is currently working as the changes are all additive.

I have no objections to pulling this change but I will hold off a little while to let Dave review the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants