Add notes for ConfigureAwait. #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
asp.net core doesn't have |
Author
|
@vchirikov indeed! I addressed this on line 612 of the first commit (609 of the final PR). |
Contributor
|
I mean it's very strange to mix up info about asp.net and asp.net core in repository with name |
Author
|
Fair point. I'll think about revising so it's more relevant. |
Contributor
|
Also you can include useful info from Stephen Toub |
davidfowl
reviewed
Mar 17, 2020
|
|
||
| :bulb:**NOTE Some advice states to use `ContinueAwait(false)` to avoid deadlocks. This is mistaken advice and does [not guarantee against deadlocks](https://blog.stephencleary.com/2012/07/dont-block-on-async-code.html).** | ||
|
|
||
| ❌ **BAD** This example uses a global object and throws a `NullReferenceException` during runtime. |
Owner
There was a problem hiding this comment.
I think we should remove the ASP.NET examples (non core) as there's nothing else in this article that tries to explain that.
sungam3r
reviewed
Jan 7, 2024
| public async Task<string> Get(int id) | ||
| { | ||
| HttpResponseMessage result; | ||
| using(var client = new HttpClient()) |
Contributor
There was a problem hiding this comment.
Suggested change
| using(var client = new HttpClient()) | |
| using (var client = new HttpClient()) |
sungam3r
reviewed
Jan 7, 2024
| var username = HttpContext.Current.Session["username"]; | ||
|
|
||
| HttpResponseMessage result; | ||
| using(var client = new HttpClient()) |
Contributor
There was a problem hiding this comment.
Suggested change
| using(var client = new HttpClient()) | |
| using (var client = new HttpClient()) |
sungam3r
reviewed
Jan 7, 2024
| public async Task<string> Get(int id) | ||
| { | ||
| HttpResponseMessage result; | ||
| using(var client = new HttpClient()) |
Contributor
There was a problem hiding this comment.
Suggested change
| using(var client = new HttpClient()) | |
| using (var client = new HttpClient()) |
sungam3r
reviewed
Jan 7, 2024
| return $"{username}, your requested content is {content}"; | ||
| } | ||
| ``` | ||
| # Scenarios |
Contributor
There was a problem hiding this comment.
Suggested change
| # Scenarios | |
| # Scenarios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filled out the TBD under
ConfigureAwait. Tried to stick to the formatting, verbiage, and style of the rest of the article. Added examples from ASP.NET Framework.