Skip to content

igr-tests: Remove remaining files from Old infrastructure #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

mobin-2008
Copy link
Collaborator

I really enjoyed my time about refactoring posix_spawn based igr-tests in #1981 but now we have a better solution for igr-tests. This new infrastructure is better and doesn't rely on limited functionalities of shell[2].

Now it's time for them to go.

[2]: 1694b96 for example

Signed-off-by: Mobin Aydinfar <[email protected]>

I really enjoyed my time about refactoring posix_spawn based igr-tests in davmac314#198[1] but
now we have a better solution for igr-tests. This new infrastructure is better and doesn't
rely on limited functionalities of shell[2].

Now it's time for them to go.

[1]: davmac314#198
[2]: davmac314@1694b96 for example

Signed-off-by: Mobin Aydinfar <[email protected]>
@mobin-2008 mobin-2008 added Enhancement/New Feature Improving things or introduce new feature A-Importance: Low Issues such as harmless typos are included in this category. C-tests Things about unit or integration tests labels Jun 23, 2024
@mobin-2008 mobin-2008 added this to the 1.0 milestone Jun 23, 2024
@mobin-2008 mobin-2008 requested a review from davmac314 June 23, 2024 14:17
Copy link
Owner

@davmac314 davmac314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@mobin-2008 mobin-2008 merged commit c1abd7a into davmac314:master Jun 24, 2024
19 checks passed
@mobin-2008 mobin-2008 deleted the igr_final_refactor branch June 24, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Importance: Low Issues such as harmless typos are included in this category. C-tests Things about unit or integration tests Enhancement/New Feature Improving things or introduce new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants