Skip to content

Fix bad formatting of line number when a service fails to load #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

JamiKettunen
Copy link
Contributor

@JamiKettunen JamiKettunen commented Oct 20, 2024

It was adding line X directly after the service file path without any kind of separation. As an example the following:

dinit: Error in service description for 'early-test' (file /etc/dinit.d/early-testline 1): badly formed line.
dinit: Error in service description for 'early-test': setting 'options' (file /etc/dinit.d/early-testline 4): unknown option: invalid

would become:

dinit: Error in service description for 'early-test' (file /etc/dinit.d/early-test, line 1): badly formed line.
dinit: Error in service description for 'early-test': setting 'options' (file /etc/dinit.d/early-test, line 4): unknown option: invalid

after this change.

It was adding "line X" directly after the service file path without any
kind of separation.
@mobin-2008 mobin-2008 added Bug/Bugfix A-Importance: Low Issues such as harmless typos are included in this category. C-dinit Things about the main parts of dinit C-dinitcheck Things about dinitcheck labels Oct 20, 2024
Copy link
Collaborator

@mobin-2008 mobin-2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Looks Good.

@mobin-2008 mobin-2008 removed the C-dinitcheck Things about dinitcheck label Oct 20, 2024
@davmac314 davmac314 merged commit ef2ce60 into davmac314:master Oct 21, 2024
21 checks passed
@JamiKettunen JamiKettunen deleted the failure-error-format-fixes branch October 21, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Importance: Low Issues such as harmless typos are included in this category. Bug/Bugfix C-dinit Things about the main parts of dinit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants