dinit-service: Do parameter substitution in consumer-of #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mobin-2008
added
Enhancement/New Feature
davmac314
requested changes
Feb 5, 2025
mobin-2008
force-pushed
the
consumer-of-$1
branch
from
50366bb to
c54872b
Compare
Done. |
davmac314
requested changes
Feb 8, 2025
Seems useful for s6-log/vlogger based logging systems. Signed-off-by: Mobin Aydinfar <[email protected]>
mobin-2008
force-pushed
the
consumer-of-$1
branch
from
c54872b to
43b45f2
Compare
davmac314
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems useful for s6-log/vlogger based logging systems.
It includes a new test:
svc-arg-consumer. I decide to add a new test for it instead of usingsvc-argbecause of usage ofprocessservices,bootservice and also dinitctl commands for testing.Fixes #427
Signed-off-by: Mobin Aydinfar <[email protected]>