Enhance metadata of sharepointLoader. #45
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raj725
reviewed
May 30, 2024
libs/community/langchain_community/document_loaders/sharepoint.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/document_loaders/sharepoint.py
Outdated
Show resolved
Hide resolved
| loader = FileSystemBlobLoader(path=temp_dir) | ||
| yield from loader.yield_blobs() | ||
| for blob in loader.yield_blobs(): | ||
| if not isinstance(blob.path, PurePath): |
There was a problem hiding this comment.
I hope this change doesn't cause any disruptions.
There was a problem hiding this comment.
@rahul-trip Is this portion fixing an existing bug unrelated to this PR? If yes, I would recommend to decouple this out and takes it up in a separate PR
Signed-off-by: Rahul Tripathi <[email protected]>
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/sharepointAuthorised
branch
from
218667e to
e192127
Compare
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/sharepointAuthorised
branch
from
9da34a0 to
f0e9e48
Compare
rahul-trip
force-pushed
the
rahul/pebblo/sharepointAuthorised
branch
2 times, most recently
from
e912a70 to
f0e9e48
Compare
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
changed the title
Signed-off-by: Rahul Tripathi <[email protected]>
rahul-trip
force-pushed
the
rahul/pebblo/sharepointAuthorised
branch
from
eda2a90 to
e33c399
Compare
Raj725
approved these changes
Jun 24, 2024
|
Closing this PR since the changes are already merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 feature flags added in this PR:
load_auth: if set to True, addsauthorised identitiesto metadataload_extended_metadata, addssource,ownerandfull_pathto metadataof SharePointLoader