Skip to content

Added docs for PebbloRetrievalQA chain #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added docs for PebbloRetrievalQA chain #50

wants to merge 1 commit into from

Conversation

Raj725
Copy link
Collaborator

@Raj725 Raj725 commented Jun 24, 2024

Thank you for contributing to LangChain!

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"

  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
    • Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!

  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.

  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@Raj725 Raj725 requested a review from srics June 24, 2024 09:59
srics
srics reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@srics srics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Rest LGTM

@Raj725
Copy link
Collaborator Author

Raj725 commented Jun 26, 2024

Closing this PR as the code/docs changes are merged to Langchain master via langchain-ai#20746

@Raj725 Raj725 closed this Jun 26, 2024
@Raj725 Raj725 deleted the pebblo_retrieval_chain_docs_v2 branch June 26, 2024 07:51
Raj725 pushed a commit that referenced this pull request Jul 4, 2024
@plageon
huggingface: Fix huggingface tei support (langchain-ai#22653)
2be66a3 
Update former pull request:
langchain-ai#22595.

Modified
`libs/partners/huggingface/langchain_huggingface/embeddings/huggingface_endpoint.py`,
where the API call function does not match current [Text Embeddings
Inference
API](https://huggingface.github.io/text-embeddings-inference/#/Text%20Embeddings%20Inference/embed).
One example is:
```json
{
  "inputs": "string",
  "normalize": true,
  "truncate": false
}
```
Parameters in `_model_kwargs` are not passed properly in the latest
version. By the way, the issue *[why cause 413?
#50](huggingface/text-embeddings-inference#50
might be solved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srics srics srics left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Raj725 @srics