-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add viewport for showing summary #1284
Conversation
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment to resolve. Nice work.
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: bryans-go <[email protected]>
Signed-off-by: bryans-go <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Divanshu Grover <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - left a minor suggestion
Signed-off-by: Divanshu Grover <[email protected]>
Signed-off-by: Divanshu Grover <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this seems to have fixed the env vars shuffling issue. Good work.
I have noticed some issues regarding displaying environment variables.
Here are a project-config add
and a multiproject example:
Project config add - some env vars missing, scrolling does not do anything
Multi-project creation - sample-go project env vars are not shown
I see the env var display although better is not perfect on main
either. Let me know if this is an easy fix as a part of this PR. Otherwise I will just open another issue for it
Signed-off-by: Divanshu Grover <[email protected]>
Signed-off-by: Divanshu Grover <[email protected]>
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: Divanshu Grover <[email protected]>
Signed-off-by: Divanshu Grover <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@divanshu-go any updates for this? |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 14 days). It will be closed if no further activity occurs. Thank you for your contribution. |
fix: add viewport for showing project / workspace summary
Description
this PR adds support for scrollable project summary by adding viewport
Related Issue(s)
Closes #1283
Closes #1298
Screenshots
Screencast.from.2024-10-23.12-17-49.mp4
Notes
Please add any relevant notes if necessary.