Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds Rust Http Server Sample #1554

Conversation

priyanshuverma-dev
Copy link
Contributor

Pull Request Title

Description

Please include a summary of the change or the feature being introduced. Include relevant motivation and context. List any dependencies that are required for this change.

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

This PR addresses issue #X

Screenshots

If relevant, please add screenshots.

Notes

Please add any relevant notes if necessary.

@priyanshuverma-dev priyanshuverma-dev requested a review from a team as a code owner December 24, 2024 11:18
Signed-off-by: Priyanshu Verma <[email protected]>
Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the spaces before the 3 colons
"name" :
into
"name":

Signed-off-by: Priyanshu Verma <[email protected]>
@idagelic
Copy link
Member

@priyanshuverma-dev Thanks, can you please only do this on your entry so that the number of lines changed stays (+5, -0)? We will then merge this

Signed-off-by: Priyanshu Verma <[email protected]>
Signed-off-by: Priyanshu Verma <[email protected]>
@priyanshuverma-dev
Copy link
Contributor Author

@idagelic Can I have a new PR? with only 5 line changes

@idagelic
Copy link
Member

@priyanshuverma-dev Sure, whatever is easiest

@priyanshuverma-dev
Copy link
Contributor Author

replace #1558

@priyanshuverma-dev priyanshuverma-dev deleted the Rust-Http-Server-Sample branch December 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants