Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new endpoint for getting dev container raw data #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rajesh-jonnalagadda
Copy link

@rajesh-jonnalagadda rajesh-jonnalagadda commented Oct 14, 2024

/claim #8

usage:
curl http://localhost:5001/?repo_url=https://github.com/rajeshj11/test-github-actions

@rajesh-jonnalagadda
Copy link
Author

@nkkko please review

@nkkko
Copy link
Member

nkkko commented Nov 5, 2024

hey, sorry, it took me some time to resolve backlog, you have killed the main route and now it serves your endpoint
image

this should be added functionality for programatic use

@rajesh-jonnalagadda
Copy link
Author

hey, sorry, it took me some time to resolve backlog, you have killed the main route and now it serves your endpoint image

this should be added functionality for programatic use

let me check

@rajesh-jonnalagadda
Copy link
Author

@nkkko fixed the breaking issue.

Signed-off-by: Rajesh Jonnalagadda <[email protected]>

chore: make repo_url optional

Signed-off-by: Rajesh Jonnalagadda <[email protected]>
@rajesh-jonnalagadda rajesh-jonnalagadda force-pushed the feat-8-add-endpoint-for-raw-data branch from e475933 to 0eeef0a Compare November 5, 2024 18:37
@rajesh-jonnalagadda
Copy link
Author

@nkkko This has been pending for a while. Do we still need these changes?

@rajesh-jonnalagadda
Copy link
Author

@nkkko This has been pending for a while. Do we still need these changes?

@nkkko ^^

@mojafa
Copy link
Contributor

mojafa commented Dec 11, 2024

@rajesh-jonnalagadda I’ve updated main with some changes that affect this PR. Could you please rebase your branch onto the latest main and resolve any conflicts that come up? Once that’s done, we can review the updated changes and move forward.

@rajesh-jonnalagadda
Copy link
Author

rajesh-jonnalagadda commented Dec 12, 2024

@rajesh-jonnalagadda I’ve updated the main with some changes that affect this PR. Could you please rebase your branch onto the latest main and resolve any conflicts that come up? Once that’s done, we can review the updated changes and move forward.

@mojafa
I have merged the latest changes from the main branch into my branch, and there are no conflicts.

@mojafa
Copy link
Contributor

mojafa commented Dec 17, 2024

@rajesh-jonnalagadda sorry for the late one. reviewing this PR

@mojafa
Copy link
Contributor

mojafa commented Dec 17, 2024

@rajesh-jonnalagadda using curl newendpoint works well:
Screenshot 2024-12-18 at 00 27 16

Screenshot 2024-12-18 at 00 29 19

@mojafa
Copy link
Contributor

mojafa commented Dec 17, 2024

however returning the devcontainer.json as plain text to allow easy piping into bash scripts or workflows for automation doesn't work. Please fix this
Screenshot 2024-12-18 at 00 32 25

Screenshot 2024-12-18 at 00 32 15

@rajesh-jonnalagadda
Copy link
Author

however returning the devcontainer.json as plain text to allow easy piping into bash scripts or workflows for automation doesn't work. Please fix this Screenshot 2024-12-18 at 00 32 25

Screenshot 2024-12-18 at 00 32 15

I did not understand this. Can you please explain to me how my changes will be reflected in the port/prod test without merging my changes?

@rajesh-jonnalagadda
Copy link
Author

rajesh-jonnalagadda commented Dec 18, 2024

however returning the devcontainer.json as plain text to allow easy piping into bash scripts or workflows for automation doesn't work. Please fix this Screenshot 2024-12-18 at 00 32 25
Screenshot 2024-12-18 at 00 32 15

I did not understand this. Can you please explain to me how my changes will be reflected in the port/prod test without merging my changes?

I'm not entirely sure, but the following command should perform the desired task locally.
curl http://localhost:5001/?repo_url=https://github.com/rajeshj11/test-github-actions > .devcontianer/devcontainer.json

note:i am using search params(?repo_url=<repor_url>) not #<repo_url>

@mojafa
Copy link
Contributor

mojafa commented Dec 18, 2024

@rajesh-jonnalagadda
This commands works well if I directly access the URL and outputs the correct devcontainer.json to the terminal. curl http://localhost:5001/?repo_url=https://devcontainer.ai/#https://github.com/daytonaio/daytona

however, when i use curl to pipe the output to a file like this:

curl http://localhost:5001/?repo_url=https://devcontainer.ai/#https://github.com/daytonaio/daytona > .devcontainer/devcontainer.json
The content in the newly generated file isn’t correct and doesn’t match the expected JSON output.

@rajesh-jonnalagadda
Copy link
Author

@rajesh-jonnalagadda This commands works well if I directly access the URL and outputs the correct devcontainer.json to the terminal. curl http://localhost:5001/?repo_url=https://devcontainer.ai/#https://github.com/daytonaio/daytona

however, when i use curl to pipe the output to a file like this:

curl http://localhost:5001/?repo_url=https://devcontainer.ai/#https://github.com/daytonaio/daytona > .devcontainer/devcontainer.json The content in the newly generated file isn’t correct and doesn’t match the expected JSON output.

Let me check

@mojafa
Copy link
Contributor

mojafa commented Dec 22, 2024

@rajesh-jonnalagadda any updates?

@rajesh-jonnalagadda
Copy link
Author

@rajesh-jonnalagadda any updates?

I'm currently participating in a hackathon and working with my team, so it may take me a few days to address this issue.

@mojafa
Copy link
Contributor

mojafa commented Dec 22, 2024

No worries

@mojafa
Copy link
Contributor

mojafa commented Jan 11, 2025

@rajesh-jonnalagadda any updates?

@rajesh-jonnalagadda
Copy link
Author

@rajesh-jonnalagadda any updates?

@mojafa
I'm still busy with the hackathon. If it's urgent, please feel free to assign it to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants