Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: introducing typed CSS Custom Properties #3128

Merged
merged 4 commits into from
Sep 23, 2024
Merged

refactor: introducing typed CSS Custom Properties #3128

merged 4 commits into from
Sep 23, 2024

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented Sep 2, 2024 •
edited
Loading

Proposed changes

Introduced typed CSS Custom Properties, starting with colors.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Sep 2, 2024
@mfranzke mfranzke added this to the v0.5.0 milestone Sep 2, 2024
@mfranzke mfranzke self-assigned this Sep 2, 2024
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/refactor-introducing-typed-css-custom-variables

@mfranzke mfranzke removed their assignment Sep 2, 2024
@mfranzke mfranzke enabled auto-merge (squash) September 2, 2024 20:00
@mfranzke mfranzke marked this pull request as draft September 2, 2024 20:15
auto-merge was automatically disabled September 2, 2024 20:15

Pull request was converted to draft

@mfranzke mfranzke mentioned this pull request Sep 12, 2024
Merged
@mfranzke mfranzke marked this pull request as ready for review September 12, 2024 20:40
@mfranzke mfranzke enabled auto-merge (squash) September 12, 2024 20:49
@mfranzke mfranzke added the 🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders label Sep 17, 2024
@mfranzke mfranzke merged commit de76cdb into main Sep 23, 2024
64 checks passed
@mfranzke mfranzke deleted the refactor-introducing-typed-css-custom-variables branch September 23, 2024 08:14
@mfranzke mfranzke removed this from the v0.5.0 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders 🏗foundations Changes inside foundations folder 🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfranzke @nmerget