Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide Web Components (StencilJS) #3174

Merged
merged 223 commits into from
Oct 29, 2024
Merged

feat: provide Web Components (StencilJS) #3174

merged 223 commits into from
Oct 29, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Sep 11, 2024 •
edited by mfranzke
Loading

Proposed changes

We need to wait for BuilderIO/mitosis#1547 until every component can be generated via mitosis.

Replaced old @db-ui/web-components with stencil build:

  • Add new stencil-showcase
  • Add playwright tests for stencil: Some of them are disabled until all components work
  • Add stencil output: can be consumed via @db-ui/web-components - Read new README.md
  • Add cem and autocompletes for JetBrain IDE's and VSCode
    • We can use the custom-elements.json for our future documentation

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Sep 11, 2024
@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Sep 11, 2024
nmerget and others added 15 commits September 11, 2024 13:22
@nmerget
fix: issue with stencil showcase build
b5b05f2
@nmerget
fix: issue with stencil showcase build
1707cba
@nmerget
Merge branch 'main' into test-stencil
e3253cf
@nmerget
fix: issues with missing stencil components for showcases
eb4f203
@nmerget
Merge remote-tracking branch 'origin/main' into test-stencil
714ba31 
# Conflicts:
#	showcases/vanilla-showcase/package.json
@nmerget
fix: issues with stencil components
dad5b1b
@nmerget
fix: issues with stencil showcase
f9e92dd
@nmerget
fix: issues with passing props from custom element
fd1c2c2
@nmerget
Merge remote-tracking branch 'origin/main' into test-stencil
5ff3f19 
# Conflicts:
#	package-lock.json
@nmerget
chore: update from main
b8a10eb
@nmerget
Merge branch 'main' into test-stencil
774ea14
@nmerget
chore: update e2e tests for stencil
cbb14f9
@nmerget
chore: update e2e tests for stencil
bb5882d
@nmerget
chore: update e2e tests for stencil
29ded4a
@nmerget
chore: update e2e tests for stencil
439e6eb
@github-actions github-actions bot added the 🏗foundations Changes inside foundations folder label Oct 29, 2024
@nmerget
fix: revert stencil showcase title for e2e tests
98d308e
@nmerget
Merge remote-tracking branch 'origin/main' into test-stencil
7702b3f 
# Conflicts:
#	__snapshots__/accordion/patternhub/accordion-properties-should-match-screenshot.png
#	__snapshots__/tabs/patternhub/tabs-properties-should-match-screenshot.png
#	__snapshots__/tag/patternhub/tag-properties-should-match-screenshot.png
#	package-lock.json
@nmerget
fix: issues with boolean values for stencil
c15a154
mfranzke
mfranzke previously approved these changes Oct 29, 2024
View reviewed changes
mfranzke
mfranzke previously approved these changes Oct 29, 2024
View reviewed changes
@nmerget nmerget requested a review from mfranzke October 29, 2024 12:34
mfranzke
mfranzke previously approved these changes Oct 29, 2024
View reviewed changes
@nmerget @mfranzke
Update output/stencil/package.json
b82f10b 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update output/stencil/package.json
29b0b61 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget nmerget requested a review from mfranzke October 29, 2024 13:50
@mfranzke
Copy link
Member

@nmerget remember, normally my reviews are gonna hurt your feelings. Now it's the pipeline.

mfranzke
mfranzke previously approved these changes Oct 29, 2024
View reviewed changes
@nmerget
Copy link
Member Author

nmerget commented Oct 29, 2024

@nmerget remember, normally my reviews are gonna hurt your feelings. Now it's the pipeline.

29b0b61 <- commit suggestion was missing the ,. But we cannot resolve who's the one creating the suggestion

@nmerget nmerget requested a review from mfranzke October 29, 2024 14:00
@mfranzke
Copy link
Member

mfranzke commented Oct 29, 2024 •
edited
Loading

@nmerget remember, normally my reviews are gonna hurt your feelings. Now it's the pipeline.

29b0b61 <- commit suggestion was missing the ,. But we cannot resolve who's the one creating the suggestion

What a pity …

@nmerget nmerget merged commit 90400bb into main Oct 29, 2024
73 checks passed
@nmerget nmerget deleted the test-stencil branch October 29, 2024 15:04
@mfranzke mfranzke added this to the v0.5.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

Assignees
No one assigned
Labels
🚢📀cicd Changes inside .github folder 🏘components Changes inside components folder 🪩 🔥 🕺 cool topic some relevant topics, that we even also need to report in different rounds / to stakeholders 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 🚀 release 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke