Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: enable correct types for properties page in patternhub #3400

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

docs: enable correct types for properties page in patternhub #3400

wants to merge 45 commits into from

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Oct 31, 2024 •
edited by mfranzke
Loading

Proposed changes

Add correct types for properties

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget enabled auto-merge (squash) October 31, 2024 12:54
@github-actions github-actions bot added 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases labels Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/docs-properties

@github-actions github-actions bot added the 🚢📀cicd Changes inside .github folder label Nov 1, 2024
nmerget and others added 8 commits November 4, 2024 12:41
@nmerget @mfranzke
Update packages/components/src/components/input/model.ts
ffe9e82 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update packages/components/src/components/header/model.ts
fbf2f3d 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update packages/components/src/components/header/model.ts
ab08899 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update packages/components/src/components/brand/model.ts
8a5ab96 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update packages/components/src/shared/model.ts
b8b7ebd 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update packages/components/src/shared/model.ts
436620b 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update packages/components/src/shared/model.ts
ba23d13 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget @mfranzke
Update packages/components/src/shared/model.ts
9949c1e 
Co-authored-by: Maximilian Franzke <[email protected]>
nmerget and others added 21 commits November 4, 2024 13:08
@nmerget
fix: issue with patternhub playwright test
013d2ae
@nmerget
fix: issue with patternhub playwright test for github action
20464a4
@nmerget @mfranzke
Update packages/components/src/components/card/model.ts
652f0b8 
Co-authored-by: Maximilian Franzke <[email protected]>
@nmerget
fix: issue with patternhub playwright test for github action
16d7f74
@nmerget
Merge remote-tracking branch 'origin/docs-properties' into docs-prope…
34a49d0 
…rties
@nmerget
fix: issue with patternhub playwright test for github action
8afe7b6
@nmerget
fix: basUrl for patternhub playwright
7dbc0bc
@nmerget
fix: baseUrl for patternhub playwright
3d8e7bc
@nmerget
Merge branch 'main' into docs-properties
5332a1c
@nmerget
Merge remote-tracking branch 'origin/main' into docs-properties
f9613ba 
# Conflicts:
#	package-lock.json
@nmerget
chore: update from main
2057bfe
@nmerget
fix: issue with bash syntax
4c48754
@nmerget
fix: issue with patternhub copy
2972a5f
@nmerget
test: additional logging
774340f
@nmerget
test: running build patternhub
492a07a
@nmerget
fix: issue with patternhub
31b869c
@nmerget
fix: issue with regenerate snapshots
90cc8dd
@nmerget
fix: issue with regenerate snapshots
e2b5368
@nmerget
chore: update snapshots
d276635
@nmerget
fix: issue with patternhub test
46d6505
@nmerget
Merge remote-tracking branch 'origin/main' into docs-properties
9e71f0a 
# Conflicts:
#	__snapshots__/drawer/patternhub/drawer-properties-should-match-screenshot.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke left review comments

@annsch annsch Awaiting requested review from annsch annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
🚢📀cicd Changes inside .github folder 🏘components Changes inside components folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke