new utc baseline for (old) schedule PR, make some datetime objs tzaware #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting TZ environment var in runtime may be required (also a good idea) schedule/test changes: * import timezone and set UTC default * adjust last_run and idle_seconds to be utc times * make until/cancel_after tzaware, update datetime strings * make should_run/run/_is_overdue use UTC times * make test_until_time use tzaware datetime for asserts * remove runtime assert, raise ScheduleError instead Signed-off-by: Stephen L Arnold <[email protected]>
|
@dbader Please review this |
Signed-off-by: Stephen L Arnold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal rework of #256 <= that needs use-case testing by interested parties. When I used the old version of ^^ that PR I had to setup the logging to use time.gmtime to get the right (UTC) log times, however, in newer py3 versions you can use https://docs.python.org/3/library/logging.html?highlight=logging%20time#logging.Formatter.formatTime (note the note about py3.9)
Hopefully someone finds this useful; I just don't have time right now to go back to my old project and try upgrading, etc. Enjoy!
Setting TZ environment var in runtime may be required (also a good idea)
schedule/test changes: