-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timezone bugfixes #623
Merged
Merged
Timezone bugfixes #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-timezone scheduling was broken. This is an attempt to fix that. To make sure this actually works in all cases, I've added a bunch of unit tests based on edge cases and reported issues. Furthermore I've split up the code a bit more to make it easier to understand and document. In this process I discovered more weird edge cases, which are now described as test cases.
Resolves #608 and #609 and #605 and #603
Everyone is invited to take a look and find more bugs / untested edge cases. Suggestions are welcome! I will leave this PR open until Saturday, after which I will merge & make a new release.
Todo:
_move_to_next_weekday
_align_utc_offset