Skip to content

Conversation

@contact-andy
Copy link

@contact-andy contact-andy commented Aug 31, 2025

This PR refines Amharic mappings and updates local statistics and ignore list as part of GSoC 2025 contributions.

Summary by CodeRabbit

  • Chores
    • Expanded the Amharic statistics ignore list to cover many additional templates, reducing noise in reported statistics and improving clarity for users viewing Amharic data.
  • Style
    • Minor formatting adjustment in Amharic mapping statistics; no functional impact on user experience.

@contact-andy contact-andy force-pushed the GSoc-2025-Amharic-Mapping branch from bee2f92 to 3d74e4d Compare August 31, 2025 11:52
@sonarqubecloud
Copy link

@JJ-Author
Copy link
Contributor

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Oct 8, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Oct 8, 2025

Walkthrough

The change updates two Amharic statistics files: a large expansion of ignore list entries for templates (including unresolved merge conflict markers) and a minor whitespace adjustment in the mapping stats file. No code or control-flow modifications are introduced.

Changes

Cohort / File(s) Summary
Ignore list — Amharic templates
server/src/main/statistics/ignorelist_am.txt
Added numerous 2010 FIFA World Cup Amharic template entries (each with 4 properties and common follow-up lines). File now contains merge conflict markers (<<<<<<<, =======, >>>>>>>) indicating unresolved conflict.
Mapping stats — formatting tweak
server/src/main/statistics/mappingstats_am.txt
Adjusted surrounding whitespace for line p|የተስፋፋ|1; repositioned after blank lines; removed end-of-file newline. No semantic changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

I thump my paws—new lists galore!
Templates hop in, then even more.
But hmm—those jagged merge-teeth bite,
Let’s smooth the seams and set them right.
Mapping whispers, “Just a space…”
I twitch my nose—onward we race! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately identifies that the pull request updates the Amharic mapping, statistics, and ignore‐list files, which matches the changeset’s content even though it lists the specific filenames.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eb0e463 and 3d74e4d.

📒 Files selected for processing (2)
  • server/src/main/statistics/ignorelist_am.txt (1 hunks)
  • server/src/main/statistics/mappingstats_am.txt (1 hunks)

Comment on lines +3 to +64
<<<<<<< HEAD
properties|0

=======
properties|8

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ኤ
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ቢ
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ሲ
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ዲ
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ኢ
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ኤፍ
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ጂ
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers

template|የ2010 እ.ኤ.አ. ፊፋ የዓለም ዋንጫ ምድብ ኤች
properties|4
የተስፋፋ
ግጥሚያዎች
scenarios
tiebreakers
>>>>>>> 6f7bcd2b9 ([GSoC'2025 Amharic Chapter] - update ignorelist_am.txt with latest exclusions)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Resolve the merge conflict markers before merging.
<<<<<<< HEAD / ======= / >>>>>>> … remain in the file, so the ignore list will not load. Clean up the conflict and keep only the intended entries.

🤖 Prompt for AI Agents
In server/src/main/statistics/ignorelist_am.txt around lines 3 to 64 there are
unresolved Git merge conflict markers (<<<<<<< HEAD / ======= / >>>>>>>) that
will break loading; remove the markers and produce a single clean file
containing only the intended ignore entries (keep the desired block(s) from
either side or merge them intentionally — e.g., retain the full set of
template/properties entries from the incoming change if that is correct), ensure
there are no leftover conflict tokens or duplicate/partial lines, save the file,
and git add/commit the resolved file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants