Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/improve sdk #603

Merged
merged 27 commits into from
Sep 3, 2023
Merged

Fix/improve sdk #603

merged 27 commits into from
Sep 3, 2023

Conversation

imotai
Copy link
Contributor

@imotai imotai commented Aug 12, 2023


PR-Codex overview

Focus of the PR:

This PR focuses on updating dependencies, adding a new function, and making changes to existing functions.

Detailed summary:

  • Updated dependencies for fastcrypto and ethers.
  • Added a new function addDoc to store a document in a collection.
  • Modified the getDoc function to handle exceptions.
  • Updated the export statement for document_v2 functions in index.ts.
  • Modified the workflow file ci.yml to run on ubuntu-latest.
  • Added a comment to explain the purpose of the addDoc function.
  • Made changes to the rollup_executor file to compress and upload record batches.
  • Added a new field evm_cost to the RollupRecord struct.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

qa-agent

This comment was marked as duplicate.

@imotai
Copy link
Contributor Author

imotai commented Aug 12, 2023

@qa-agent

@qa-agent
Copy link

Unit Test Analysis

🎯level:Important
🥋explanation:The pull request modifies the code in the store/document_v2.ts file, which contains important functions for adding and updating documents. It is important to have unit tests for these functions to ensure that they work correctly and handle different scenarios.

Existing Test Cases

Summary Category File
Test that the addDoc function can be called successfully. positive testing sdk/tests/client_v2.test.ts
Test that the addDoc function throws an exception for invalid inputs. negative testing sdk/tests/client_v2.test.ts

Recommended Test Cases

Summary Category
Test that the addDoc function works correctly under different edge cases, such as null inputs, empty inputs, and large inputs. edge testing

@imotai
Copy link
Contributor Author

imotai commented Aug 12, 2023

@qa-agent

@qa-agent
Copy link

Unit Test Analysis

🎯level:Important
📣explanation:The pull request modifies the code in the store/document_v2.ts file, which contains important functions for adding and updating documents. It is important to have unit tests for these functions to ensure that they work correctly and handle errors properly.

Existing Test Cases

Summary Category File
Test that the addDoc function can be called successfully. positive testing sdk/tests/client_v2.test.ts
Test that the addDoc function throws an exception for invalid inputs. negative testing sdk/tests/client_v2.test.ts

Recommended Test Cases

Summary Category
Test that the addDoc function works correctly under different edge cases, such as null inputs, empty inputs, and large inputs. edge testing

@codecov-commenter
Copy link

Codecov Report

Merging #603 (ff95ca4) into main (518b627) will increase coverage by 0.53%.
Report is 3 commits behind head on main.
The diff coverage is 76.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   61.70%   62.24%   +0.53%     
==========================================
  Files           9        9              
  Lines         470      482      +12     
  Branches       69       71       +2     
==========================================
+ Hits          290      300      +10     
- Misses        180      182       +2     
Flag Coverage Δ
rust 62.24% <76.92%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdk/src/store/document_v2.ts 84.61% <57.14%> (-2.35%) ⬇️
sdk/src/provider/indexer_provider.ts 75.60% <100.00%> (+4.18%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imotai imotai merged commit a98ec98 into main Sep 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants