You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎯level:Important
🥋explanation:The pull request modifies the code in the store/document_v2.ts file, which contains important functions for adding and updating documents. It is important to have unit tests for these functions to ensure that they work correctly and handle different scenarios.
Existing Test Cases
Summary
Category
File
Test that the addDoc function can be called successfully.
positive testing
sdk/tests/client_v2.test.ts
Test that the addDoc function throws an exception for invalid inputs.
negative testing
sdk/tests/client_v2.test.ts
Recommended Test Cases
Summary
Category
Test that the addDoc function works correctly under different edge cases, such as null inputs, empty inputs, and large inputs.
🎯level:Important
📣explanation:The pull request modifies the code in the store/document_v2.ts file, which contains important functions for adding and updating documents. It is important to have unit tests for these functions to ensure that they work correctly and handle errors properly.
Existing Test Cases
Summary
Category
File
Test that the addDoc function can be called successfully.
positive testing
sdk/tests/client_v2.test.ts
Test that the addDoc function throws an exception for invalid inputs.
negative testing
sdk/tests/client_v2.test.ts
Recommended Test Cases
Summary
Category
Test that the addDoc function works correctly under different edge cases, such as null inputs, empty inputs, and large inputs.
Merging #603 (ff95ca4) into main (518b627) will increase coverage by 0.53%.
Report is 3 commits behind head on main.
The diff coverage is 76.92%.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
Focus of the PR:
This PR focuses on updating dependencies, adding a new function, and making changes to existing functions.
Detailed summary:
addDoc
to store a document in a collection.getDoc
function to handle exceptions.document_v2
functions inindex.ts
.ci.yml
to run on ubuntu-latest.addDoc
function.rollup_executor
file to compress and upload record batches.evm_cost
to theRollupRecord
struct.