-
Notifications
You must be signed in to change notification settings - Fork 146
Adding support for Snowflake Workload Identity Federation #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @roryjbd |
CLA now signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions but this looks good, will work on getting OIDC set up this week to test
Also can you add the environment variables your tests need to the github action? dbt-adapters/.github/workflows/_integration-tests.yml Lines 329 to 330 in 91b04c4
|
I've just updated the integration tests to use |
Thank you for your pull request! We could not find a changelog entry for this change in the dbt-snowflake package. For details on how to document a change, see the Contributing Guide. |
@colin-rogers-dbt Let me sort the f-string and changelog entry! |
resolves #1234
Issue raised for updating docs
dbt-labs/docs.getdbt.com#7866
Problem
Allows for authentication to Snowflake using Workload Identity Federation
Solution
Allows the necessary parameters to be passed to the snowflake connector
connect
method.Updates to latest supported
snowflake-connector-python
package.Checklist