Skip to content

Conversation

roryjbd
Copy link

@roryjbd roryjbd commented Sep 4, 2025

resolves #1234
Issue raised for updating docs
dbt-labs/docs.getdbt.com#7866

Problem

Allows for authentication to Snowflake using Workload Identity Federation

Solution

Allows the necessary parameters to be passed to the snowflake connector connect method.
Updates to latest supported snowflake-connector-python package.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@roryjbd roryjbd requested a review from a team as a code owner September 4, 2025 15:14
Copy link

cla-bot bot commented Sep 4, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @roryjbd

@roryjbd
Copy link
Author

roryjbd commented Sep 4, 2025

CLA now signed

@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Sep 4, 2025
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions but this looks good, will work on getting OIDC set up this week to test

@colin-rogers-dbt
Copy link
Contributor

Also can you add the environment variables your tests need to the github action?

env:
SNOWFLAKE_TEST_ACCOUNT: ${{ secrets.SNOWFLAKE_TEST_ACCOUNT }}

@roryjbd
Copy link
Author

roryjbd commented Sep 9, 2025

Also can you add the environment variables your tests need to the github action?

env:
SNOWFLAKE_TEST_ACCOUNT: ${{ secrets.SNOWFLAKE_TEST_ACCOUNT }}

I've just updated the integration tests to use SNOWFLAKE_TEST_USER instead of SNOWFLAKE_TEST_WIF_USER - so no additional env vars required now. It'll be possible to add WIF as an additonal auth method to existing user that you have for integration tests. Just alter user instead of creating a new user.

Copy link
Contributor

github-actions bot commented Sep 9, 2025

Thank you for your pull request! We could not find a changelog entry for this change in the dbt-snowflake package. For details on how to document a change, see the Contributing Guide.

@roryjbd
Copy link
Author

roryjbd commented Sep 9, 2025

@colin-rogers-dbt Let me sort the f-string and changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for Snowflake Workload Identity Federation
2 participants