Support Recording Classmethods That are Overriden by Instance Methods #287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recording code was crashing when attempting to wrap a method override, specifically when the method on the parent class was a classmethod, but the override is an instance method. Such an override is a poor programming practice, and we should look at removing them, but we also shouldn't crash during recording.
This change makes recording work as well as possible in such cases, and avoids a crash.
Checklist
changie new
to create a changelog entry