Skip to content

Capturing BadGzipFile exception in connection_exception_retry #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leaomatheus
Copy link
Contributor

resolves #290

Issue described in #290

Description

This is a transient failure that can be resolved by capturing the right exception.

Checklist

@leaomatheus leaomatheus requested a review from a team as a code owner May 30, 2025 22:18
@cla-bot cla-bot bot added the cla:yes label May 30, 2025
@leaomatheus
Copy link
Contributor Author

@peterallenwebb @MichelleArk, sorry for the direct ping but I suspect you are the right people I should tag based on git history -- can you help get this small change merged, either by approving the pull request or redirecting to the appropriate person? Thanks in advance!

Copy link
Collaborator

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, clean and simple! Thank you for doing this work ❤️

@QMalcolm
Copy link
Collaborator

QMalcolm commented Jul 1, 2025

Closing and re-opening to get the CI actions kicked off 🤔

@QMalcolm QMalcolm closed this Jul 1, 2025
@QMalcolm QMalcolm reopened this Jul 1, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (0cfefb3) to head (cce9edf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   71.86%   71.87%           
=======================================
  Files          52       52           
  Lines        3633     3634    +1     
=======================================
+ Hits         2611     2612    +1     
  Misses       1022     1022           
Flag Coverage Δ
unit 71.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@QMalcolm QMalcolm merged commit ef1cfcb into dbt-labs:main Jul 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Downloading a dbt package may fail with BadGzipFile
3 participants