Begin tracking add adapter types to invocation context #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking `multiple` adapter types instead of an individual adapter type is perhaps a premature optimization. However I'm doing it to be defensively foward thinking. There are currently vague plans of multi adapter support. There isn't, to my knowledge, exactly how far out on the road map, but it is a known direction. When we get to that point, we'll need the invocation context to be able to handle knowing about multiple adapters. Switching to an iterable now is a little odd, given for the time being it'll only ever have one item. However, once we begin work on multi-adapter support, this will make that future work easier.
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 71.88% 71.87% -0.02%
==========================================
Files 52 52
Lines 3635 3644 +9
==========================================
+ Hits 2613 2619 +6
- Misses 1022 1025 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichelleArk
approved these changes
Jul 15, 2025
MichelleArk
deleted the
qmalcolm--292-add-adapter-type-to-invocation-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #292
Description
We want to keep track of the adapter types being used in an invocation. This is necessary for dbt-labs/dbt-core#11828
Checklist
changie newto create a changelog entry