Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retry docs generate by marking certain args as False by default. #10742

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jordivandooren
Copy link

Resolves #10741

Problem

dbt retry raises NoSuchOption after dbt docs generate

Solution

Add static and empty_catalog to the list of flags that are nog saved to the run_results.json file when they are absent.
A second strategy could have been to add the exceptions to retry.py top prevent these options (while present in the run results) to be translated into --no-.

Checklist

Type hints could be better; I could not find a clean way to express args should be "dictable" (should have __dict__).

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@jordivandooren jordivandooren requested a review from a team as a code owner September 19, 2024 16:01
@cla-bot cla-bot bot added the cla:yes label Sep 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (3308a43) to head (4e07487).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10742      +/-   ##
==========================================
- Coverage   88.97%   88.95%   -0.02%     
==========================================
  Files         181      181              
  Lines       22971    22971              
==========================================
- Hits        20438    20435       -3     
- Misses       2533     2536       +3     
Flag Coverage Δ
integration 86.13% <100.00%> (-0.02%) ⬇️
unit 62.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.39% <100.00%> (ø)
Integration Tests 86.13% <100.00%> (-0.02%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] dbt retry does not work for dbt docs generate
1 participant