Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add automation for proto generation #10971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 4, 2024

Resolves #10970

Problem

proto file is generated with inconsistent versions.

Solution

Automate the generation so the version is consistent.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Nov 4, 2024
@emmyoop emmyoop requested a review from a team as a code owner November 4, 2024 16:14
@cla-bot cla-bot bot added the cla:yes label Nov 4, 2024
@emmyoop emmyoop added the proto update update proto definitions in CI label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (bdf28d7) to head (e2f4772).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10971      +/-   ##
==========================================
- Coverage   89.14%   89.13%   -0.01%     
==========================================
  Files         183      183              
  Lines       23553    23553              
==========================================
- Hits        20996    20994       -2     
- Misses       2557     2559       +2     
Flag Coverage Δ
integration 86.51% <ø> (ø)
unit 62.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.76% <ø> (ø)
Integration Tests 86.51% <ø> (ø)

Comment on lines +25 to +27
file_path: "core/dbt/events/core_types_pb2.py"
make_command: "core_proto_types"
pr-branch: ${{ github.event.pull_request.head.ref }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes proto update update proto definitions in CI Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate proto generation with a workflow
2 participants