-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Functional test for hourly microbatch model #11220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11220 +/- ##
==========================================
- Coverage 88.89% 88.84% -0.05%
==========================================
Files 191 191
Lines 24391 24397 +6
==========================================
- Hits 21682 21676 -6
- Misses 2709 2721 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This reverts commit 65a1db0. Reverting this because `batch_start` for `format_batch_start` cannot be `None` and `start_time` for `batch_id` cannot be `None`.
QMalcolm
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11165
Problem
For hourly microbatch models that run concurrently (like Snowflake), the batch id can have spaces which causes an invalid name for the temporary table and leads to a database error.
Solution
Only use alphanumeric characters within batch ids.
Since the most granular batch size is
hour
, the simplest solution might be to use the ISO8601 basic format for time using an hour granularity:Checklist