Skip to content

[1.9.latest] Support reading package 'name' in package-lock.yml, but do not write #11662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2025

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented May 23, 2025

Resolves #11661

Problem

Starting in dbt-core v1.10, package-lock.yml includes the name attribute for each package. This causes incompatibility errors if the user then downgrades back to v1.9, or runs the project on different versions in different environments.

Solution

For v1.9: Support reading name in package-lock.yml, but do not actually write it

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label May 23, 2025
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.11%. Comparing base (ab93b10) to head (3f2254f).
Report is 1 commits behind head on 1.9.latest.

Additional details and impacted files
@@             Coverage Diff             @@
##           1.9.latest   #11662   +/-   ##
===========================================
  Coverage       89.10%   89.11%           
===========================================
  Files             184      184           
  Lines           23941    23949    +8     
===========================================
+ Hits            21333    21341    +8     
  Misses           2608     2608           
Flag Coverage Δ
integration 86.49% <100.00%> (-0.01%) ⬇️
unit 62.20% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.20% <77.77%> (+<0.01%) ⬆️
Integration Tests 86.49% <100.00%> (-0.01%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtcohen6 jtcohen6 force-pushed the jerco/cherry-pick-11488 branch from 52a37b1 to 537f525 Compare May 23, 2025 13:35
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@jtcohen6 jtcohen6 marked this pull request as ready for review May 28, 2025 10:31
@jtcohen6 jtcohen6 requested a review from a team as a code owner May 28, 2025 10:31
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work ❤️

@QMalcolm QMalcolm merged commit 46ed0ea into 1.9.latest Jun 3, 2025
52 checks passed
@QMalcolm QMalcolm deleted the jerco/cherry-pick-11488 branch June 3, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants