Skip to content

Fix #11506: Add freshness config to sources (#11628) #11683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025

Conversation

QMalcolm
Copy link
Contributor

Resolves #11681

Problem

1.9.latest needs to support freshness within source config

Solution

Backport #11628

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

* Fix #11506: Add freshness config to exposures

* Add freshness to some config

* Update Fixes-20250515-145857.yaml

* Add PropertyMovedToConfigDeprecation

* make core_proto_types

* Add log check

* Use +freshness instead of freshness

* Fix test_events.py
@QMalcolm QMalcolm requested a review from a team as a code owner May 27, 2025 22:16
@cla-bot cla-bot bot added the cla:yes label May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.03%. Comparing base (1651bbd) to head (6fcf7d4).
Report is 1 commits behind head on 1.9.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.9.latest   #11683      +/-   ##
==============================================
- Coverage       89.10%   89.03%   -0.07%     
==============================================
  Files             184      184              
  Lines           23911    23928      +17     
==============================================
  Hits            21305    21305              
- Misses           2606     2623      +17     
Flag Coverage Δ
integration 86.35% <89.28%> (-0.19%) ⬇️
unit 62.16% <78.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.16% <78.57%> (+0.01%) ⬆️
Integration Tests 86.35% <89.28%> (-0.19%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@QMalcolm QMalcolm added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label May 27, 2025
@QMalcolm QMalcolm merged commit 941b4b7 into 1.9.latest May 28, 2025
90 of 92 checks passed
@QMalcolm QMalcolm deleted the backport-11628-to-1.9.latest branch May 28, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants