Skip to content

Backport #11719 to 1.9.latest #11721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Conversation

QMalcolm
Copy link
Contributor

Resolves #11717

Problem

We had broken the backwards compatibility of freshness on the parsed source node

Solution

Backport #11719

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

#11719)

* Ensure source node `.freshness` is equal to node's `.config.freshness`

* Default source config freshness to empty spec if no freshenss spec is given

* Update contract tests for source nodes
@QMalcolm QMalcolm requested a review from a team as a code owner June 10, 2025 15:16
@cla-bot cla-bot bot added the cla:yes label Jun 10, 2025
@QMalcolm QMalcolm added the artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking label Jun 10, 2025
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (c20c71a) to head (96b495f).
Report is 1 commits behind head on 1.9.latest.

Additional details and impacted files
@@              Coverage Diff               @@
##           1.9.latest   #11721      +/-   ##
==============================================
- Coverage       89.11%   89.06%   -0.06%     
==============================================
  Files             184      184              
  Lines           23949    23949              
==============================================
- Hits            21342    21330      -12     
- Misses           2607     2619      +12     
Flag Coverage Δ
integration 86.38% <100.00%> (-0.12%) ⬇️
unit 62.15% <100.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.15% <100.00%> (-0.18%) ⬇️
Integration Tests 86.38% <100.00%> (-0.12%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@QMalcolm QMalcolm merged commit 9fdac8a into 1.9.latest Jun 10, 2025
98 of 104 checks passed
@QMalcolm QMalcolm deleted the backport-11719-to-1.9.latest branch June 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants