Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mirnawong1
commented
Oct 30, 2024
mirnawong1
commented
Oct 30, 2024
joellabes
requested changes
Oct 30, 2024
Contributor
joellabes
left a comment
There was a problem hiding this comment.
This looks great! A few suggested tweaks and clarifications but overall :chef_kiss:
|
|
||
| When configured, `event_time` enables compare changes to: | ||
|
|
||
| - Compare data in CI versus production for overlapping times only, reducing false discrepancies. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Compare data in CI versus production for overlapping times only, reducing false discrepancies. | |
| - Compare data in CI against production for only the overlapping times, avoiding false positives and returning results faster. |
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
mirnawong1
commented
Nov 15, 2024
mirnawong1
commented
Nov 15, 2024
mirnawong1
commented
Nov 15, 2024
| ``` | ||
| </File> | ||
|
|
||
| This setup sets `record_timestamp` as the `event_time` for `my_seed`. It ensures that the `record_timestamp` is used consistently in [Advanced CI's compare changes](/docs/deploy/advanced-ci#speeding-up-comparisons) or [incremental microbatching](/docs/build/incremental-microbatch). |
Contributor
Author
There was a problem hiding this comment.
since it was midway through, i was just trying to add a reminder of the effect it has on advanced ci or microbatch. but is overkill so removing
mirnawong1
commented
Nov 15, 2024
Collaborator
graciegoheen
left a comment
There was a problem hiding this comment.
Few final nits otherwise ready to go! thank you!
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
Contributor
|
Check your created Crawler Check your created index on your Algolia Application |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds a new page for the
event_timeconfig for models, sources, snapshots, and sources.also adds to the advanced ci and links from other pages.
this PR #6384 will merge into this pr.
docs notion
some. outstanding items:
🚀 Deployment available! Here are the direct links to the updated files: