Test optimization of queries containing metrics withfill_nulls_with set
#1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forms when loading a JSON-serialized manifest
plypaul
changed the title
fill_nulls_with setfill_nulls_with set
tlento
approved these changes
Jan 21, 2026
Contributor
tlento
left a comment
tlento
left a comment
There was a problem hiding this comment.
Oh hey, I can see that the optimizer does nothing!
nit: can you delete the vestigial snapshots? Doesn't matter much but it can be annoying down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the following optimization case:
fill_nulls_withset.This includes some refactoring of the tests - please view by commit.